impala-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (IMPALA-4818) TestCancellationSerial.test_cancel_insert is meta-flaky
Date Thu, 27 Apr 2017 21:26:04 GMT

     [ https://issues.apache.org/jira/browse/IMPALA-4818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jim Apple resolved IMPALA-4818.
-------------------------------
    Resolution: Fixed


IMPALA-4818: Ensure the same number of tests are run every time

This is a partial revert of Change-Id: I04b4d6db508a26a1a2e4b972b...
from January 2014. That commit caused test_cancel_insert to run
different random tests each time it was run; the number of tests run
could vary between 1 and 9. This commit fixes the number at 9, and the
same 9 every time, to avoid test flakiness.

Change-Id: I22cecfbe7c9a102f788d01eb80aa188579ef6d7e
Reviewed-on: http://gerrit.cloudera.org:8080/5784
Reviewed-by: Michael Brown <mikeb@cloudera.com>
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Impala Public Jenkins

> TestCancellationSerial.test_cancel_insert is meta-flaky
> -------------------------------------------------------
>
>                 Key: IMPALA-4818
>                 URL: https://issues.apache.org/jira/browse/IMPALA-4818
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Infrastructure
>    Affects Versions: Impala 2.9.0
>            Reporter: Jim Apple
>            Priority: Critical
>              Labels: flaky
>
> Found by [~dknupp]: {{TestCancellationSerial.test_cancel_insert}} is so flaky that it
doesn't even run the same number of test cases each time:
> {noformat}
> jbapple@jbapple-optiplex:~/Impala/tests:((detached from gerrit-asf/master))$ impala-py.test
--exploration_strategy=core --collect-only query_test/test_cancellation.py | grep -c insert
> 7
> jbapple@jbapple-optiplex:~/Impala/tests:((detached from gerrit-asf/master))$ impala-py.test
--exploration_strategy=core --collect-only query_test/test_cancellation.py | grep -c insert
> 4
> jbapple@jbapple-optiplex:~/Impala/tests:((detached from gerrit-asf/master))$ impala-py.test
--exploration_strategy=core --collect-only query_test/test_cancellation.py | grep -c insert
> 3
> jbapple@jbapple-optiplex:~/Impala/tests:((detached from gerrit-asf/master))$ impala-py.test
--exploration_strategy=core --collect-only query_test/test_cancellation.py | grep -c insert
> 8
> jbapple@jbapple-optiplex:~/Impala/tests:((detached from gerrit-asf/master))$ impala-py.test
--exploration_strategy=core --collect-only query_test/test_cancellation.py | grep -c insert
> 7
> {noformat}
> http://jenkins.impala.io:8080/job/ubuntu-14.04-from-scratch/657 and http://jenkins.impala.io:8080/job/ubuntu-14.04-from-scratch/661
ran the same code:
> {{GIT_HASH: 3426a04952eb5ee906b732b4644ce77c0d24fa7e}}
> But they have different numbers of {{test_cancel_insert}} runs: #657 has 9 and #661 has
5, leading to #657 reporting:
> {noformat}
> =============== 1624 tests deselected by "-m 'execute_serially'" ===============
>  187 passed, 8 skipped, 1624 deselected, 1 xfailed, 24 warnings in 1944.18 seconds 
> {noformat}
> While #661 reports:
> {noformat}
> =============== 1624 tests deselected by "-m 'execute_serially'" ===============
>  183 passed, 8 skipped, 1624 deselected, 1 xfailed, 24 warnings in 1958.31 seconds 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message