impala-issues-all mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (Jira)" <j...@apache.org>
Subject [jira] [Commented] (IMPALA-9755) Flaky test: test_global_exchange_counters
Date Wed, 20 May 2020 17:45:00 GMT

    [ https://issues.apache.org/jira/browse/IMPALA-9755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112480#comment-17112480
] 

ASF subversion and git services commented on IMPALA-9755:
---------------------------------------------------------

Commit 95ee26354dc0ce61e5844430d1eaf553fd13d154 in impala's branch refs/heads/master from
Sahil Takiar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=95ee263 ]

IMPALA-9755: Flaky test: test_global_exchange_counters

De-flake TestObservability.test_global_exchange_counters in
test_observability.py.

IMPALA-6984 added a feature to send a Cancel RPC to running fragments
when the coordinator fragment fetches all rows defined by a limit. This
causes fragments to terminate early (which is a good thing). However,
test_global_exchange_counters expects each fragment to produce some
rows, which is why it recently became flaky.

This patch modifies test_global_exchange_counters so that it allows for
some fragments to produce 0 rows.

Testing:
* Ran test_observability.py locally
* Looped 8 concurrent streams of test_global_exchange_counters for an
  hour, no failures (previously I was able to reproduce the test issue
  within 5 minutes)

Change-Id: Icb3a1b5ccb5695eb71343e96cc830f12d5c72f1e
Reviewed-on: http://gerrit.cloudera.org:8080/15960
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>


> Flaky test: test_global_exchange_counters
> -----------------------------------------
>
>                 Key: IMPALA-9755
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9755
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Infrastructure
>            Reporter: Tim Armstrong
>            Assignee: Sahil Takiar
>            Priority: Blocker
>              Labels: flaky
>
> {noformat}
> query_test.test_observability.TestObservability.test_global_exchange_counters (from pytest)
> Failing for the past 1 build (Since Failed#10637 )
> Took 22 sec.
> add description
> Error Message
> query_test/test_observability.py:504: in test_global_exchange_counters     assert m,
"Cannot match pattern for key %s in line '%s'" % (key, line) E   AssertionError: Cannot match
pattern for key TotalBytesSent in line '           - TotalBytesSent: 0' E   assert None
> Stacktrace
> query_test/test_observability.py:504: in test_global_exchange_counters
>     assert m, "Cannot match pattern for key %s in line '%s'" % (key, line)
> E   AssertionError: Cannot match pattern for key TotalBytesSent in line '           -
TotalBytesSent: 0'
> E   assert None
> {noformat}
> https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/10637/testReport/junit/query_test.test_observability/TestObservability/test_global_exchange_counters/
> Filing in case it reoccurs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org


Mime
View raw message