Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A5397200D66 for ; Fri, 29 Dec 2017 20:12:42 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A3761160C33; Fri, 29 Dec 2017 19:12:42 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4BC27160C16 for ; Fri, 29 Dec 2017 20:12:41 +0100 (CET) Received: (qmail 45879 invoked by uid 500); 29 Dec 2017 19:12:40 -0000 Mailing-List: contact dev-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.apache.org Delivered-To: mailing list dev@impala.apache.org Received: (qmail 45867 invoked by uid 99); 29 Dec 2017 19:12:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Dec 2017 19:12:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A22671A0273 for ; Fri, 29 Dec 2017 19:12:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.379 X-Spam-Level: ** X-Spam-Status: No, score=2.379 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=cloudera.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id LniUA7Q1TuAu for ; Fri, 29 Dec 2017 19:12:35 +0000 (UTC) Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com [209.85.215.46]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 7F5505F2AD for ; Fri, 29 Dec 2017 19:12:34 +0000 (UTC) Received: by mail-lf0-f46.google.com with SMTP id o26so34686214lfc.10 for ; Fri, 29 Dec 2017 11:12:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudera.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=Oq8CBu8AvHjQ8fkDRAjsGiUqJbTYhlf1ALiQq55Nw4k=; b=pvzDg6wsKSlJg/4zluf41HDA2prCI05ES8SrYiXWeCzvJO/irEKIcEy4sbDs8k7wcW QlHRybuqY6Ef+sKmJoqn0TL9saJzmViLaQjjvKF2WVxD4HlPDfSnNCgL4o7mfUmB8gWB SAMv6k1vEx2gHkXP54z7ZGxKzjHhXczp5jwoc4RoyjHUK5oLaV2DmamrNAy3sfTNwV2F oe0zv8Zj3m8PTce2mMR5nNYjR+mJMq3YDUS6khkUb3UabrjxngVwolPffW9F5AGUE+DQ x8Ss2YHE6UJ9PyCVxUsdgla94VyePFEvl2tlt3Fkvfipr3kRi2GHkRsSjp8MQpuhCb7u LsNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=Oq8CBu8AvHjQ8fkDRAjsGiUqJbTYhlf1ALiQq55Nw4k=; b=cAVvuVe5YrjoK2qWvTgU8ALLBi5cahcIT60LWRTLhx0qe14zZgCGfLsZzPCe06sri4 dy2v6NmSTa1GBair52faWHXV0aL7NWZOjpynYbvAq3k1SFYkDxN8tpzANz5hkn2WK+ws oiE9o55Hk87Q4wArfpEQIehCEMwjolmUtDBcNqAsjOTAo3N61DxShlfd5e5lmjSLHsw2 8lsDuqc48m6KPLQbWN+H7YVAe2rKHPhInrB6bdZwAzZD+iwRo9BtifCLoyk8gyZEyKcC zuIptJtf837SKnM64YUpLRLbfnuqTJn+v1xnCWEpPuZAgAj6AdzqG5qLOsR1Y6LZiG3r LQkg== X-Gm-Message-State: AKGB3mKnomKDrapOpD4zqECvU/49VgEQ7OKyYCKfPJtuS+/XmA3uWGt7 ZucFbjQaZMM9pqI1CPh2LwjvVaNKs5qWRayogO6mj/kJ X-Google-Smtp-Source: ACJfBosz/T8H7Sn8QgeFHdNah13g2hwF6B40zG0zum93EWHpkWbc5gQYxolVCVyvhIfvYYt0WK6/W8NHqzMSpY7VYL4= X-Received: by 10.46.21.87 with SMTP id 23mr20498210ljv.107.1514574752720; Fri, 29 Dec 2017 11:12:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.166.9 with HTTP; Fri, 29 Dec 2017 11:12:31 -0800 (PST) In-Reply-To: References: From: Manaswini Maharana Date: Fri, 29 Dec 2017 14:12:31 -0500 Message-ID: Subject: Re: New Impala Contributors: IMPALA-6296 To: dev Content-Type: multipart/mixed; boundary="94eb2c1cd0e81f8ae505617f6ae7" archived-at: Fri, 29 Dec 2017 19:12:42 -0000 --94eb2c1cd0e81f8ae505617f6ae7 Content-Type: multipart/alternative; boundary="94eb2c1cd0e81f8add05617f6ae5" --94eb2c1cd0e81f8add05617f6ae5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I've pushed the initial changes to - https://gerrit.cloudera.org/#/c/8923/ Steps that I've followed to make this contribution - As this is my first, I want to elaborate a little bit to ensure I'm covering the bases right. 1. After the following the extensive contribution guide = , setup the development environment on machine with Ubuntu 16.04 OS, 15 GB memory, Intel=C2=AE Core=E2=84=A2 i7-8550U CPU @ 1.80GHz =C3=97 8 & 512 GB= SSD 2. Modified the build process to avoiding building against -so (IMPALA-5365 & IMPALA-3926) 3. Reproduced the issue. Attached Impalad error log. 4. Put in the code fix - added a condition check to ensure 'emit_perf_map_' evaluates to true before the dependent object(perf_map_lock_) is asserted using DCHECK. 5. Unit tested the changes using Impala-shell. No daemon crash encountered this time. 6. Loaded and ran the "be" unit test cases to ensure the change did not break other stuff. Attached the results. Questions I have: 1. Is it recommened to run more end-to-end unit tests or does it depend on the intensity of the change ? Like here I've limited it to just running be tests, is that ok? 2. As per Tim's comment, I should see *.asm files in codegen-modules after the fix, but I don't see any. Am I missing anything ? Thanks & appreciate your input, Mansi On Fri, Dec 29, 2017 at 12:43 PM, Manaswini Maharana wrote: > Thank you! > > On Fri, Dec 29, 2017 at 11:47 AM, Jim Apple wrote: > >> Done >> On Fri, Dec 29, 2017 at 7:12 AM, Manaswini Maharana >> wrote: >> > username: mmaharana >> > >> > On Fri, Dec 29, 2017 at 10:07 AM, Jin Chul Kim >> wrote: >> > >> >> Hi, >> >> >> >> I guess she doesn't have a privilege to change assignee. The permissi= on >> >> should be provided by somebody who has an admin privilege. >> >> @Mansi, please share your username. >> >> >> >> Best regards, >> >> Jinchul >> >> >> >> 2017-12-30 0:02 GMT+09:00 Vincent Tran : >> >> >> >> > You should be able to just simply "assign to me" if you are signed >> into >> >> ADD >> >> > Jira. >> >> > >> >> > On Dec 29, 2017 9:54 AM, "Manaswini Maharana" < >> mmaharana@cloudera.com> >> >> > wrote: >> >> > >> >> > > Good morning, Team - any update on this? >> >> > > >> >> > > - Mansi >> >> > > >> >> > > >> >> > > On Thu, Dec 28, 2017 at 12:32 AM, Manaswini Maharana < >> >> > > mmaharana@cloudera.com >> >> > > > wrote: >> >> > > >> >> > > > Hello team, I'd like to contribute to Impala and would like to >> start >> >> it >> >> > > > with this (IMPALA-6296) jira. Can I please have it assigned to >> me? >> >> > > > >> >> > > > My development environment is ready. I'm on ubuntu 16.04 so yes >> some >> >> > > > challenges to set up the environment especially with the >> >> > LD_LIBRARY_PATH >> >> > > > issues. So far I'm able to work past it and might ask for anoth= er >> >> pair >> >> > of >> >> > > > eyes to ensure it follows standard. The builds are going fine a= nd >> >> runs >> >> > a >> >> > > > bit longer as I've disabled the -so. Apart from setup, I'm was >> able >> >> to >> >> > > > reproduce the issue and might have been ready with the fix whic= h >> I'd >> >> > like >> >> > > > to discuss once I'm officially assigned the jira. >> >> > > > >> >> > > > Thanks Tim, for the instructions, it was very helpful. >> >> > > > >> >> > > > >> >> > > > Thanks! >> >> > > > Mansi >> >> > > > >> >> > > > >> >> > > > >> >> > > > On Tue, Dec 12, 2017 at 8:24 PM, Tim Armstrong < >> >> > tarmstrong@cloudera.com> >> >> > > > wrote: >> >> > > > >> >> > > >> If you'd like to contribute a patch to Impala, but aren't sure >> what >> >> > > >> you want to work on, you can look at Impala's newbie issues: >> >> > > >> https://issues.apache.org/jira/issues/?filter=3D12341668. You = can >> >> find >> >> > > >> detailed instructions on submitting patches at >> >> > > >> https://cwiki.apache.org/confluence/display/IMPALA/ >> >> > > Contributing+to+Impala >> >> > > >> . >> >> > > >> This is a walkthrough of a ticket a new contributor could take >> on, >> >> > > >> with hopefully enough detail to get you going but not so much = to >> >> take >> >> > > >> away the fun. >> >> > > >> >> >> > > >> How can we solve https://issues.apache.org/jira >> /browse/IMPALA-6296, >> >> > > >> "DCheck in CodegenSymbolEmitter when --asm_module_dir is set o= n >> >> debug >> >> > > >> build >> >> > > >> "? >> >> > > >> First, make sure you have your development environment set up. >> Let's >> >> > > >> see if we can reproduce the issue. >> >> > > >> >> >> > > >> Create a directory for the codegen modules then start >> impala-server >> >> > > >> $ mkdir codegen-modules >> >> > > >> $ start-impala-cluster.py --impalad_args=3D"--opt_module_d >> >> > > >> ir=3Dcodegen-modules >> >> > > >> --unopt_module_dir=3Dcodegen-modules --asm_module_dir=3Dcodege= n- >> >> modules" >> >> > > >> >> >> > > >> Now run a query through Impala. I chose this query because it >> uses >> >> > > >> Impala's >> >> > > >> runtime code generation ("codegen") to improve performance >> >> > > >> $ bin/impala-shell.sh -q "select count(*) from tpch.lineitem" >> >> > > >> >> >> > > >> After a few seconds, you should see an error from Impala >> crashing: >> >> > > >> Error communicating with impalad: TSocket read 0 bytes >> >> > > >> Could not execute command: select count(*) from tpch.lineitem >> >> > > >> >> >> > > >> Attempting to run any further queries will fail because of the >> >> crashed >> >> > > >> Impala daemons: >> >> > > >> $ impala-shell.sh -q "select count(*) from tpch.lineitem"; >> >> > > >> Starting Impala Shell without Kerberos authentication >> >> > > >> Error connecting: TTransportException, Could not connect to >> >> > > >> localhost:21000 >> >> > > >> Not connected to Impala, could not execute queries. >> >> > > >> >> >> > > >> If you look at logs/cluster/impalad.ERROR you will see a messa= ge >> >> > > >> explaining >> >> > > >> the crash - we hit a DCHECK (a.k.a. an assertion): >> >> > > >> >> >> > > >> F1212 17:10:07.642722 9138 codegen-symbol-emitter.cc:90] Chec= k >> >> > failed: >> >> > > >> perf_map_.find(obj.getData().data()) !=3D perf_map_.end() >> >> > > >> *** Check failure stack trace: *** >> >> > > >> @ 0x3be16ed google::LogMessage::Fail() >> >> > > >> @ 0x3be2f92 google::LogMessage::SendToLog() >> >> > > >> @ 0x3be10c7 google::LogMessage::Flush() >> >> > > >> @ 0x3be468e google::LogMessageFatal::~ >> >> LogMessageFatal() >> >> > > >> @ 0x1b354f1 >> >> > > >> impala::CodegenSymbolEmitter::NotifyFreeingObject() >> >> > > >> @ 0x375b791 llvm::MCJIT::NotifyFreeingObject() >> >> > > >> @ 0x375b811 llvm::MCJIT::~MCJIT() >> >> > > >> @ 0x375bfc9 llvm::MCJIT::~MCJIT() >> >> > > >> @ 0x1b265ba std::default_delete<>::operator()() >> >> > > >> @ 0x1b23e21 std::unique_ptr<>::reset() >> >> > > >> @ 0x1b11198 impala::LlvmCodeGen::Close() >> >> > > >> @ 0x182194d impala::RuntimeState::ReleaseR >> esources() >> >> > > >> @ 0x1893a35 impala::FragmentInstanceState: >> :Close() >> >> > > >> @ 0x1890d58 impala::FragmentInstanceState::Exec(= ) >> >> > > >> @ 0x1879afa impala::QueryState::ExecFInstance() >> >> > > >> @ 0x18783bc >> >> > > >> _ZZN6impala10QueryState15StartFInstancesEvENKUlvE_clEv >> >> > > >> @ 0x187a739 >> >> > > >> _ZN5boost6detail8function26void_function_obj_invoker0IZN6imp >> >> > > >> ala10QueryState15StartFInstancesEvEUlvE_vE6invokeERNS1_ >> >> > > 15function_bufferE >> >> > > >> @ 0x17c7200 boost::function0<>::operator()() >> >> > > >> @ 0x1abdf8b impala::Thread::SuperviseThread() >> >> > > >> @ 0x1ac6b16 boost::_bi::list4<>::operator()<>() >> >> > > >> @ 0x1ac6a59 boost::_bi::bind_t<>::operator()() >> >> > > >> @ 0x1ac6a1c boost::detail::thread_data<>::run() >> >> > > >> @ 0x2d6b08a thread_proxy >> >> > > >> @ 0x7fcb5ff146ba start_thread >> >> > > >> @ 0x7fcb5fc4a3dd clone >> >> > > >> >> >> > > >> It looks like something is wrong with the code - 'perf_map_' >> doesn't >> >> > > have >> >> > > >> anything in it. If we look a few lines above, it looks like >> >> > 'perf_map_' >> >> > > is >> >> > > >> only filled in if 'emit_perf_map_' is true. >> >> > > >> >> >> > > >> if (emit_perf_map_) { >> >> > > >> lock_guard perf_map_lock(perf_map_lock_); >> >> > > >> DCHECK(perf_map_.find(obj.getData().data()) =3D=3D >> >> perf_map_.end()); >> >> > > >> perf_map_[obj.getData().data()] =3D >> std::move(perf_map_entries); >> >> > > >> WritePerfMapLocked(); >> >> > > >> } >> >> > > >> >> >> > > >> Maybe we should also be checking 'emit_perf_map_' before the >> DCHECK? >> >> > > >> >> >> > > >> After you have fixed this bug, you should be able to run the >> query >> >> > > without >> >> > > >> Impala crashing and you should be able to inspect the assembly >> >> > generated >> >> > > >> by >> >> > > >> Impala in codegen-modules/*.asm >> >> > > >> >> >> > > >> Have fun, and don't be afraid to ask dev@impala.apache.org is >> you >> >> > have >> >> > > >> any questions! >> >> > > >> >> >> > > > >> >> > > > >> >> > > >> >> > >> >> >> > > --94eb2c1cd0e81f8add05617f6ae5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
=
5. Unit tested the changes using Impala-shell. No daemon crash encount= ered this time.
6. Loaded and ran the "be" unit test ca= ses to ensure the change did not break other stuff. Attached the results.


Questions I have: =
1. Is it recommened to run more end-to-end unit tests or doe= s it depend on the intensity of the change ? Like here I've limited it = to just running be tests, is that ok?
2. As per Tim's comment= , I should see *.asm files in codegen-modules after the fix, but I don'= t see any. Am I missing anything ?

=
Thanks & appreciate your input,
Mansi


On Fri, Dec= 29, 2017 at 12:43 PM, Manaswini Maharana <mmaharana@cloudera.com= > wrote:
Thank you!

On Fri, Dec 29, 2017 at 11:47 AM, Jim Apple= <jbapple@cloudera.com> wrote:
Done
On Fri, Dec 29, 2017 at 7:12 AM, Manaswini Maharana
<mmaharana@cloudera.com> wrote:
> username: mmaharana
>
> On Fri, Dec 29, 2017 at 10:07 AM, Jin Chul Kim <jinchul@gmail.com> wrote:
>
>> Hi,
>>
>> I guess she doesn't have a privilege to change assignee. The p= ermission
>> should be provided by somebody who has an admin privilege.
>> @Mansi, please share your username.
>>
>> Best regards,
>> Jinchul
>>
>> 2017-12-30 0:02 GMT+09:00 Vincent Tran <vttran@cloudera.com>:
>>
>> > You should be able to just simply "assign to me" if= you are signed into
>> ADD
>> > Jira.
>> >
>> > On Dec 29, 2017 9:54 AM, "Manaswini Maharana" <<= a href=3D"mailto:mmaharana@cloudera.com" target=3D"_blank">mmaharana@cloude= ra.com>
>> > wrote:
>> >
>> > > Good morning, Team - any update on this?
>> > >
>> > > - Mansi
>> > >
>> > >
>> > > On Thu, Dec 28, 2017 at 12:32 AM, Manaswini Maharana <= ;
>> > > mmaharana@cloudera.com
>> > > > wrote:
>> > >
>> > > > Hello team, I'd like to contribute to Impala an= d would like to start
>> it
>> > > > with this (IMPALA-6296) jira. Can I please have it = assigned to me?
>> > > >
>> > > > My development environment is ready. I'm on ubu= ntu 16.04 so yes some
>> > > > challenges to set up the environment especially wit= h the
>> > LD_LIBRARY_PATH
>> > > > issues. So far I'm able to work past it and mig= ht ask for another
>> pair
>> > of
>> > > > eyes to ensure it follows standard. The builds are = going fine and
>> runs
>> > a
>> > > > bit longer as I've disabled the -so. Apart from= setup, I'm was able
>> to
>> > > > reproduce the issue and might have been ready with = the fix which I'd
>> > like
>> > > > to discuss=C2=A0 once I'm officially assigned t= he jira.
>> > > >
>> > > > Thanks Tim, for the instructions, it was very helpf= ul.
>> > > >
>> > > >
>> > > > Thanks!
>> > > > Mansi
>> > > >
>> > > >
>> > > >
>> > > > On Tue, Dec 12, 2017 at 8:24 PM, Tim Armstrong <=
>> > = tarmstrong@cloudera.com>
>> > > > wrote:
>> > > >
>> > > >> If you'd like to contribute a patch to Impa= la, but aren't sure what
>> > > >> you want to work on, you can look at Impala'= ;s newbie issues:
>> > > >> https://issues.a= pache.org/jira/issues/?filter=3D12341668. You can
>> find
>> > > >> detailed instructions on submitting patches at<= br> >> > > >> https://cwiki.apache.= org/confluence/display/IMPALA/
>> > > Contributing+to+Impala
>> > > >> .
>> > > >> This is a walkthrough of a ticket a new contrib= utor could take on,
>> > > >> with hopefully enough detail to get you going b= ut not so much to
>> take
>> > > >> away the fun.
>> > > >>
>> > > >> How can we solve https:= //issues.apache.org/jira/browse/IMPALA-6296,
>> > > >> "DCheck in CodegenSymbolEmitter when --asm= _module_dir is set on
>> debug
>> > > >> build
>> > > >> "?
>> > > >> First, make sure you have your development envi= ronment set up. Let's
>> > > >> see if we can reproduce the issue.
>> > > >>
>> > > >> Create a directory for the codegen modules then= start impala-server
>> > > >> $ mkdir codegen-modules
>> > > >> $ start-impala-cluster.py --impalad_args=3D&quo= t;--opt_module_d
>> > > >> ir=3Dcodegen-modules
>> > > >> --unopt_module_dir=3Dcodegen-modules --asm= _module_dir=3Dcodegen-
>> modules"
>> > > >>
>> > > >> Now run a query through Impala. I chose this qu= ery because it uses
>> > > >> Impala's
>> > > >> runtime code generation ("codegen") t= o improve performance
>> > > >> $ bin/impala-shell.sh -q "select count(*) = from tpch.lineitem"
>> > > >>
>> > > >> After a few seconds, you should see an error fr= om Impala crashing:
>> > > >> Error communicating with impalad: TSocket read = 0 bytes
>> > > >> Could not execute command: select count(*) from= tpch.lineitem
>> > > >>
>> > > >> Attempting to run any further queries will fail= because of the
>> crashed
>> > > >> Impala daemons:
>> > > >> $ impala-shell.sh -q "select count(*) from= tpch.lineitem";
>> > > >> Starting Impala Shell without Kerberos authenti= cation
>> > > >> Error connecting: TTransportException, Could no= t connect to
>> > > >> localhost:21000
>> > > >> Not connected to Impala, could not execute quer= ies.
>> > > >>
>> > > >> If you look at logs/cluster/impalad.ERROR you w= ill see a message
>> > > >> explaining
>> > > >> the crash - we hit a DCHECK (a.k.a. an assertio= n):
>> > > >>
>> > > >> F1212 17:10:07.642722=C2=A0 9138 codegen-symbol= -emitter.cc:90] Check
>> > failed:
>> > > >> perf_map_.find(obj.getData().data()) !=3D = perf_map_.end()
>> > > >> *** Check failure stack trace: ***
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x3be16ed=C2=A0 google::LogMessage::Fail()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x3be2f92=C2=A0 google::LogMessage::SendToLog()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x3be10c7=C2=A0 google::LogMessage::Flush()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x3be468e=C2=A0 google::LogMessageFatal::~
>> LogMessageFatal()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x1b354f1
>> > > >> impala::CodegenSymbolEmitter::NotifyFreein= gObject()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x375b791=C2=A0 llvm::MCJIT::NotifyFreeingObject()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x375b811=C2=A0 llvm::MCJIT::~MCJIT()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x375bfc9=C2=A0 llvm::MCJIT::~MCJIT()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x1b265ba=C2=A0 std::default_delete<>::operator()()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x1b23e21=C2=A0 std::unique_ptr<>::reset()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x1b11198=C2=A0 impala::LlvmCodeGen::Close()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x182194d=C2=A0 impala::RuntimeState::ReleaseResources()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x1893a35=C2=A0 impala::FragmentInstanceState::Close()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x1890d58=C2=A0 impala::FragmentInstanceState::Exec()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x1879afa=C2=A0 impala::QueryState::ExecFInstance()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x18783bc
>> > > >> _ZZN6impala10QueryState15StartFInstancesEv= ENKUlvE_clEv
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x187a739
>> > > >> _ZN5boost6detail8function26void_function_o= bj_invoker0IZN6imp
>> > > >> ala10QueryState15StartFInstancesEvEUlvE_vE= 6invokeERNS1_
>> > > 15function_bufferE
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x17c7200=C2=A0 boost::function0<>::operator()()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x1abdf8b=C2=A0 impala::Thread::SuperviseThread()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x1ac6b16=C2=A0 boost::_bi::list4<>::operator()<>(= )
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x1ac6a59=C2=A0 boost::_bi::bind_t<>::operator()()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x1ac6a1c=C2=A0 boost::detail::thread_data<>::run()
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0x2d6b08a=C2=A0 thread_proxy
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A00x7fcb5= ff146ba=C2=A0 start_thread
>> > > >>=C2=A0 =C2=A0 =C2=A0@=C2=A0 =C2=A0 =C2=A00x7fcb5= fc4a3dd=C2=A0 clone
>> > > >>
>> > > >> It looks like something is wrong with the code = - 'perf_map_' doesn't
>> > > have
>> > > >> anything in it. If we look a few lines above, i= t looks like
>> > 'perf_map_'
>> > > is
>> > > >> only filled in if 'emit_perf_map_' is t= rue.
>> > > >>
>> > > >>=C2=A0 =C2=A0if (emit_perf_map_) {
>> > > >>=C2=A0 =C2=A0 =C2=A0lock_guard<SpinLock> p= erf_map_lock(perf_map_lock_);
>> > > >>=C2=A0 =C2=A0 =C2=A0DCHECK(perf_map_.find(obj.ge= tData().data()) =3D=3D
>> perf_map_.end());
>> > > >>=C2=A0 =C2=A0 =C2=A0perf_map_[obj.getData().data= ()] =3D std::move(perf_map_entries);
>> > > >>=C2=A0 =C2=A0 =C2=A0WritePerfMapLocked();
>> > > >>=C2=A0 =C2=A0}
>> > > >>
>> > > >> Maybe we should also be checking 'emit_perf= _map_' before the DCHECK?
>> > > >>
>> > > >> After you have fixed this bug, you should be ab= le to run the query
>> > > without
>> > > >> Impala crashing and you should be able to inspe= ct the assembly
>> > generated
>> > > >> by
>> > > >> Impala in codegen-modules/*.asm
>> > > >>
>> > > >> Have fun, and don't be afraid to ask dev@impala.apache.org<= /a> is you
>> > have
>> > > >> any questions!
>> > > >>
>> > > >
>> > > >
>> > >
>> >
>>


--94eb2c1cd0e81f8add05617f6ae5-- --94eb2c1cd0e81f8ae505617f6ae7--