Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
MIME-Version: 1.0
In-Reply-To: <CADZba-Qs1J-U33fNkKBtZyJM+upOjFJywPXgKFaHdWVgYKUU2w@mail.gmail.com>
References: <CADZba-Qs1J-U33fNkKBtZyJM+upOjFJywPXgKFaHdWVgYKUU2w@mail.gmail.com>
From: Jim Apple <jbapple@cloudera.com>
Date: Wed, 12 Jul 2017 17:15:27 -0700
Message-ID: <CAC-pSX0icPtD=iJbfoYbhgjyGC_qfUTasEYsWGCm-=hX13aExw@mail.gmail.com>
Subject: Re: Disabling all clang-tidy checks
To: "dev@impala" <dev@impala.incubator.apache.org>
Content-Type: multipart/alternative; boundary="94eb2c0820ecd4f682055427d62c"
archived-at: Thu, 13 Jul 2017 00:23:41 -0000

--94eb2c0820ecd4f682055427d62c
Content-Type: text/plain; charset="UTF-8"

What about "diagnostic-henry-thinks-will-never-fire,-*,-clang-diagnostic-*"?


On Wed, Jul 12, 2017 at 5:01 PM, Henry Robinson <henry@apache.org> wrote:

> Has anyone found a way to disable all clang-tidy checks for a directory?
>
> I've tried a directory-specific .clang-tidy file with
>
> ---
> Checks: "-*"
>
> but that causes clang-tidy to exit with an error (because I didn't
> configure any checks). So I tried adding one check that I thought would
> never fire. But that silently re-enables a bunch of clang-diagnostic*
> checks that I don't want.
>
> This happens when running:
>
> git diff HEAD~1 |
>  "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/share/clan
> g/clang-tidy-diff.py"
> -clang-tidy-binary
> "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/bin/clang-tidy" -p 1
>
> per
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65868536
>
> Any ideas? Am I running clang-tidy wrong?
>

--94eb2c0820ecd4f682055427d62c--