impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Behm <alex.b...@cloudera.com>
Subject Re: Renaming prefix-named tests (IMPALA-4721)
Date Wed, 04 Jan 2017 19:54:21 GMT
Before we go down that route, isn't there a proper Pytest way to run only a
single test within a .py file?
Our -k option is meant to filter based on a regex, not necessarily select a
single test.

On Wed, Jan 4, 2017 at 1:28 AM, Lars Volker <lv@cloudera.com> wrote:

> Hi all,
>
> Some of our test names are also prefixes of other tests, e.g.
> in tests/metadata/test_ddl.py we have *test_create_table* and
> *test_create_table_as_select*. Selecting the former with "impala-py.test -k
> test_create_table" will also select the latter.
>
> In the past when I ran into these I renamed the prefix-named test, usually
> by adding "_test" to make them unique. However this is somewhat unintuitive
> and consequently needed explanation during reviews. To improve the
> situation, I would like to propose changing all affected tests in a single
> commit.
>
> Before doing that, I'd like to ask for feedback. I created IMPALA-4721
> <https://issues.cloudera.org/browse/IMPALA-4721> to track this.
>
> Thanks, Lars
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message