impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Armstrong <tarmstr...@cloudera.com>
Subject Re: Contributing ppc specific patches for Impala's native-toolchain
Date Fri, 09 Dec 2016 18:29:56 GMT
I'd like to echo Jim's point. We're not really equipped to do code review
for changes to toolchain components so we generally only want to have
trivial or upstream patches in the toolchain.

On Tue, Dec 6, 2016 at 4:51 AM, Jim Apple <jbapple@cloudera.com> wrote:

> Have you already started the process of submitting patches upstream to the
> breakpad and kudu projects themselves? Toolchain is usually a thin wrapper
> around the projects it uses, not major modification patchsets.
>
> On Tue, Dec 6, 2016 at 4:30 AM, Valencia Serrao <vserrao@us.ibm.com>
> wrote:
>
>> Hi Tim,
>>
>> Thanks for the information.
>>
>> I understand your concern w.r.t PPCLE h/w availability at your end.
>> Regarding the code changes, though modifications to the toolchain's build
>> scripts themselves are not too complicated, however, for specific
>> components like breakpad, kudu, etc, we did have to do some major
>> modifications to port them onto ppc.
>>
>> Regards,
>> Valencia
>>
>> [image: Inactive hide details for Tim Armstrong ---12/05/2016 10:18:28
>> PM---Please submit any code reviews for native-toolchain via Clo]Tim
>> Armstrong ---12/05/2016 10:18:28 PM---Please submit any code reviews for
>> native-toolchain via Cloudera's public gerrit: https://gerrit.clo
>>
>> From: Tim Armstrong <tarmstrong@cloudera.com>
>> To: "dev@impala" <dev@impala.incubator.apache.org>
>> Cc: Valencia Serrao/Austin/Contr/IBM@IBMUS, Nishidha
>> Panpaliya/Austin/Contr/IBM@IBMUS, Sudarshan
>> Jagadale/Austin/Contr/IBM@IBMUS, Manish Patil/Austin/Contr/IBM@IBMUS
>> Date: 12/05/2016 10:18 PM
>> Subject: Re: Contributing ppc specific patches for Impala's
>> native-toolchain
>> ------------------------------
>>
>>
>>
>> Please submit any code reviews for native-toolchain via Cloudera's public
>> gerrit: *https://gerrit.cloudera.org/#/admin/projects/Toolchain*
>> <https://gerrit.cloudera.org/#/admin/projects/Toolchain>. The
>> native-toolchain project is still under Cloudera rather than ASF but the
>> code review process is similar.
>>
>> We'll need to consider is how to test the changes without access to PPCLE
>> hardware, since maintainers will still need to work on and maintain that
>> code.
>>
>> Are the changes large or invasive?
>>
>> Thanks,
>> Tim
>>
>> On Mon, Dec 5, 2016 at 2:38 AM, Valencia Serrao <*vserrao@us.ibm.com*
>> <vserrao@us.ibm.com>> wrote:
>>
>>
>>    Hi All,
>>
>>    I'm glad to inform that we have been able to port Impala's
>>    native-toolchain onto ppc. Going forward, we would like to contribute
>>    the
>>    patches. Please let us know what will be the best approach for this,
>>    i.e.
>>
>>    1. Fork native-toolchain to our github repo and create a PR for each
>>    of the
>>    fixes, or
>>    2. If we are provided with the write access on native-toolchain repo,
>>    create a separate branch for ppc on native-toolchain's repo and push
>>    our
>>    ppc specific changes on it.
>>
>>
>>    Regards,
>>    Valencia
>>
>>
>>
>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message