impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] IMPALA-4650: Add protobuf 2.6.1 to toolchain
Date Tue, 13 Dec 2016 01:57:51 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4650: Add protobuf 2.6.1 to toolchain
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5479/1/source/protobuf/build.sh
File source/protobuf/build.sh:

PS1, Line 2: 2015
> nit: 2016?
Done


Line 16: # cleans and rebuilds thirdparty/. The Impala build environment must be set up
> Old comment?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4c7ecedf22d44213aff7a4999ba99d8868f41d
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message