impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lars Volker ...@cloudera.com>
Subject Re: clang-tidy
Date Tue, 08 Nov 2016 11:17:36 GMT
Thank you Jim for working on this!

On Fri, Nov 4, 2016 at 5:38 PM, Jim Apple <jbapple@cloudera.com> wrote:

> clang-tidy is a nice tool for catching likely bugs and definitely poor
> syntax. You can use it on your latest patch with:
>
> git diff asf-gerrit/master |
> "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/share/
> clang/clang-tidy-diff.py"
> -clang-tidy-binary
> "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/bin/clang-tidy" -p 1
>
> You can check the whole repo with:
>
> bin/run_clang_tidy.sh
>
> The latter produces a lot of output and takes 10-15 minutes. Warnings
> are lines that end in ']'.
>
> Time permitting, I will expand the checks we use and try to integrate
> this into tests or code review tools. I added it to the wiki:
>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65868536
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message