impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] IMPALA-3399: Add DITA Open Toolkit to build Impala user docs.
Date Wed, 02 Nov 2016 04:58:16 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3399: Add DITA Open Toolkit to build Impala user docs.
......................................................................


Patch Set 1:

I think we can avoid making this part of native-toolchain since it looks like pure Java code
that doesn't depend on any other parts of the toolchain and isn't platform-dependent.

This would also make the native toolchain dependent on Gradle, which I believe will download
things from the internet, rather than just our S3 source buckets.

How about we just add the build script to the Impala repository? I could see hosting the source
on S3 but it might also be good to support building directly from the original github tag.

-- 
To view, visit http://gerrit.cloudera.org:8080/4902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1110b8c8dc5a9333143055afd49734fc336a1f0
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message