impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henry Robinson <he...@cloudera.com>
Subject Re: A modest proposal: use the gold linker by default
Date Fri, 14 Oct 2016 17:58:32 GMT
I'm in favour of the switch, assuming that the details can be worked out.
Reducing the variability in the tools used to build Impala is worthwhile in
and of itself.

On 13 October 2016 at 08:52, Tim Armstrong <tarmstrong@cloudera.com> wrote:

> Oh interesting. It doesn't look like our toolchain version of binutils
> (2.26) has the fix, but 2.27 does have it.
>
> On Thu, Oct 13, 2016 at 8:48 AM, Todd Lipcon <todd@cloudera.com> wrote:
>
> > There's one issue with older versions of gold that for shared objects it
> > doesn't handle weak symbols correctly:
> > https://sourceware.org/bugzilla/show_bug.cgi?id=16979
> >
> > This isn't a problem for static linking, but for dynamic linking causes
> > problems like not seeing tcmalloc's version of malloc.
> >
> > Not a blocker (I use gold almost all the time on my laptop by putting a
> > symlink on my path as 'ld') but something to be aware of.
> >
> > -Todd
> >
> > On Thu, Oct 13, 2016 at 8:28 AM, Jim Apple <jbapple@cloudera.com> wrote:
> >
> > > I think clang doesn't have a CLI option to use gold. Does buildall.sh
> > -asan
> > > interact well with gold?
> > >
> > > On Thu, Oct 13, 2016 at 8:25 AM, Tim Armstrong <
> tarmstrong@cloudera.com>
> > > wrote:
> > >
> > > > The gold linker is much faster for building static binaries so will
> be
> > > much
> > > > friendlier for new developers.
> > > >
> > > > I don't think I've seen a problem attributable to gold since it was
> > > added ~
> > > > 6 months ago. I've been using it since then and we've been using it
> for
> > > > some Impala test jobs as well for at least a couple of months. I feel
> > > > confident that any major problems have been shaken out.
> > > >
> > > > Does anyone have any objections?
> > > >
> > > > - Tim
> > > >
> > >
> >
> >
> >
> > --
> > Todd Lipcon
> > Software Engineer, Cloudera
> >
>



-- 
Henry Robinson
Software Engineer
Cloudera
415-994-6679

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message