impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] Versioning of build artifacts
Date Tue, 18 Oct 2016 01:08:43 GMT
Matthew Jacobs has posted comments on this change.

Change subject: Versioning of build artifacts
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4742/1/functions.sh
File functions.sh:

PS1, Line 425: git rev-parse
how about getting a short hash (I think --short) to make this a bit more human-friendly.

We could even start using tags in the future if we want.


-- 
To view, visit http://gerrit.cloudera.org:8080/4742
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb8774a7bd4bcae0c135684078f5ce89a28f6bc2
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message