Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A2C8D200B74 for ; Thu, 1 Sep 2016 21:44:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A1A69160AC9; Thu, 1 Sep 2016 19:44:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E1944160ACF for ; Thu, 1 Sep 2016 21:44:58 +0200 (CEST) Received: (qmail 57871 invoked by uid 500); 1 Sep 2016 19:44:58 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 57642 invoked by uid 99); 1 Sep 2016 19:44:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Sep 2016 19:44:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 6EA8AC1446 for ; Thu, 1 Sep 2016 19:44:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ppIbJLbTmfVt for ; Thu, 1 Sep 2016 19:44:55 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id F365160DA1 for ; Thu, 1 Sep 2016 19:44:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u81JirDb003631; Thu, 1 Sep 2016 19:44:53 GMT Date: Thu, 1 Sep 2016 19:44:53 +0000 From: "Thomas Tauber-Marshall (Code Review)" To: Henry Robinson , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Sailesh Mukil Message-ID: Reply-To: tmarshall@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-CR=5D_IMPALA-3972=3A_Improve_display_of_/varz_page=0A?= X-Gerrit-Change-Id: I5a0d47da7abf913918d5fba5c327e26b73d701d2 X-Gerrit-ChangeURL: X-Gerrit-Commit: e2efb6e4e348a014155b636adf3e582a8d37fa5e MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 01 Sep 2016 19:44:59 -0000 Hello Henry Robinson, Internal Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4228 to review the following change. Change subject: IMPALA-3972: Improve display of /varz page ...................................................................... IMPALA-3972: Improve display of /varz page gflags has an API that returns metadata for all command-line flags. This patch changes /varz to use that to generate a table view, where rows are highlighted if the flag has changed from its default value. Change-Id: I5a0d47da7abf913918d5fba5c327e26b73d701d2 Reviewed-on: http://gerrit.cloudera.org:8080/3941 Reviewed-by: Henry Robinson Tested-by: Internal Jenkins (cherry picked from commit fe97579fe805b34bdccf4569ac626d11801a4823) --- M be/src/util/default-path-handlers.cc M www/common-header.tmpl A www/flags.tmpl 3 files changed, 96 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/28/4228/1 -- To view, visit http://gerrit.cloudera.org:8080/4228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5a0d47da7abf913918d5fba5c327e26b73d701d2 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Sailesh Mukil