Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3007C200B74 for ; Thu, 1 Sep 2016 10:48:57 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 24E46160AB7; Thu, 1 Sep 2016 08:48:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6AC49160AAE for ; Thu, 1 Sep 2016 10:48:36 +0200 (CEST) Received: (qmail 24868 invoked by uid 500); 1 Sep 2016 08:48:35 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 24841 invoked by uid 99); 1 Sep 2016 08:48:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Sep 2016 08:48:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 8CEE71A606E for ; Thu, 1 Sep 2016 08:48:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 33uamvMAr5Xb for ; Thu, 1 Sep 2016 08:48:32 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id 791195FC06 for ; Thu, 1 Sep 2016 08:48:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u818mVqO023057; Thu, 1 Sep 2016 08:48:31 GMT Date: Thu, 1 Sep 2016 08:48:31 +0000 From: "Youwei Wang (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Youwei Wang Message-ID: Reply-To: youwei.a.wang@intel.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_Impala-4058=3A_unaligned_memory_access_issue_in_SIMDed_byteswap=2E=0A?= X-Gerrit-Change-Id: I2986991f8b695d68af465fd0aff293d3d03709a0 X-Gerrit-ChangeURL: X-Gerrit-Commit: 404f0d4292a8eecc2b7542cbf1535e17091c9cde MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 01 Sep 2016 08:48:57 -0000 Youwei Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/4198 Change subject: Impala-4058: unaligned memory access issue in SIMDed byteswap. ...................................................................... Impala-4058: unaligned memory access issue in SIMDed byteswap. Substitute the direct memory assignments using _mm_loadu_si128/_mm_storeu_si128 to prevent the compiler from generating aligned memory access instructions which may cause crash. Add new test cases in the expr-test.cc and re-run the bswap-benchmark. No performance regression observed. Change-Id: I2986991f8b695d68af465fd0aff293d3d03709a0 --- M be/src/exprs/expr-test.cc M be/src/util/bit-util.cc 2 files changed, 24 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/98/4198/1 -- To view, visit http://gerrit.cloudera.org:8080/4198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2986991f8b695d68af465fd0aff293d3d03709a0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang