Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A9B96200B88 for ; Thu, 8 Sep 2016 00:41:36 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A82D2160ACF; Wed, 7 Sep 2016 22:41:36 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EFB76160AC1 for ; Thu, 8 Sep 2016 00:41:35 +0200 (CEST) Received: (qmail 2456 invoked by uid 500); 7 Sep 2016 22:41:35 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 2444 invoked by uid 99); 7 Sep 2016 22:41:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Sep 2016 22:41:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8F6CF1806A5 for ; Wed, 7 Sep 2016 22:41:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id W3T-rLzrZyep for ; Wed, 7 Sep 2016 22:41:30 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 2A26B5F1F3 for ; Wed, 7 Sep 2016 22:41:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u87MfTYp018835; Wed, 7 Sep 2016 22:41:29 GMT Message-Id: <201609072241.u87MfTYp018835@ip-10-146-233-104.ec2.internal> Date: Wed, 7 Sep 2016 22:41:29 +0000 From: "Marcel Kornacker (Code Review)" To: Alex Behm , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Tim Armstrong Reply-To: marcel@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3905=3A_Add_single-threaded_scan_node=2E=0A?= X-Gerrit-Change-Id: I98cc7f970e1575dd83875609985e1877ada3d5e0 X-Gerrit-ChangeURL: X-Gerrit-Commit: bf3cf14cf7998c81cc9f91c1e6cc1d8a2f248684 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 07 Sep 2016 22:41:36 -0000 Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3905: Add single-threaded scan node. ...................................................................... Patch Set 7: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/4113/6/be/src/exec/hdfs-scan-node-base.h File be/src/exec/hdfs-scan-node-base.h: Line 304: bool unknown_disk_id_warned_; > Done ? http://gerrit.cloudera.org:8080/#/c/4113/7/be/src/exec/hdfs-scan-node.h File be/src/exec/hdfs-scan-node.h: Line 104: boost::lock_guard l(file_type_counts_); move to .cc, this isn't perf-critical and doesn't need to be inlined (it's nice to keep extra fluff out of headers) Line 141: /// This lock cannot be taken together with any other lock except lock_. what is required lock order? -- To view, visit http://gerrit.cloudera.org:8080/4113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98cc7f970e1575dd83875609985e1877ada3d5e0 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes