Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 67D63200B78 for ; Fri, 2 Sep 2016 22:26:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 666A1160AAE; Fri, 2 Sep 2016 20:26:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id ACADB160A8C for ; Fri, 2 Sep 2016 22:26:26 +0200 (CEST) Received: (qmail 36691 invoked by uid 500); 2 Sep 2016 20:26:25 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 36680 invoked by uid 99); 2 Sep 2016 20:26:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Sep 2016 20:26:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1D650185F16 for ; Fri, 2 Sep 2016 20:26:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 08SGdzP1Ipfh for ; Fri, 2 Sep 2016 20:26:23 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 5D1975FBCB for ; Fri, 2 Sep 2016 20:26:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u82KQJnJ006233; Fri, 2 Sep 2016 20:26:19 GMT Message-Id: <201609022026.u82KQJnJ006233@ip-10-146-233-104.ec2.internal> Date: Fri, 2 Sep 2016 20:26:19 +0000 From: "Jim Apple (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Jim Apple Reply-To: jbapple@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4058=3A_benchmark_byteswap_on_misaligned_memory=0A?= X-Gerrit-Change-Id: Ia9dfcca718b2456488d0fb4407d3817c796bfad0 X-Gerrit-ChangeURL: X-Gerrit-Commit: 94e06f16890ff94fc3cec7f935e84d57556c0edf In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Fri, 02 Sep 2016 20:26:27 -0000 Jim Apple has posted comments on this change. Change subject: IMPALA-4058: benchmark byteswap on misaligned memory ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4290/4/be/src/benchmarks/bswap-benchmark.cc File be/src/benchmarks/bswap-benchmark.cc: Line 20: #include nit: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes -- To view, visit http://gerrit.cloudera.org:8080/4290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9dfcca718b2456488d0fb4407d3817c796bfad0 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes