impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anonymous Coward (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4100, IMPALA-4112: RQG-on-Hive: Replace EXTRACT UDF and IS [NOT] DISTINCT FROM in HiveSqlWriter
Date Fri, 09 Sep 2016 22:13:00 GMT
stakiar@cloudera.com has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4357

Change subject: IMPALA-4100, IMPALA-4112: RQG-on-Hive: Replace EXTRACT UDF and IS [NOT] DISTINCT
FROM in HiveSqlWriter
......................................................................

IMPALA-4100, IMPALA-4112: RQG-on-Hive: Replace EXTRACT UDF and IS [NOT] DISTINCT FROM in HiveSqlWriter

IMPALA-4100:

* Postgres and Impala support EXTRACT([field] from [date-type]), but Hive doesn't
* Hive has other UDFs that perform the same function, but they have different names
* This commit modifies the HiveSqlWriter to use the corresponding Hive functions

IMPALA-4112:

* Postgres and Impala support IS [NOT] DISTINCT FROM clauses as a null safe equals
* Hive doesn't support this clause, but has a null safe equals operator: <=>
* This commit modifies the HiveSqlWriter to use <=> instead of IS [NOT] DISTINCT FROM

Testing:

* This commit only modifies the HiveSqlWriter, so no testing against Impala was done
* Tested locally against Hive

Change-Id: I3922ca61af59ecd2899c911b1a03e11ab5c26e11
---
M tests/comparison/model_translator.py
1 file changed, 25 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/4357/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3922ca61af59ecd2899c911b1a03e11ab5c26e11
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: stakiar@cloudera.com

Mime
View raw message