impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR] IMPALA-3969: stress test: add option to set common query options
Date Thu, 01 Sep 2016 19:44:52 GMT
Hello David Knupp, Tim Armstrong,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4225

to review the following change.

Change subject: IMPALA-3969: stress test: add option to set common query options
......................................................................

IMPALA-3969: stress test: add option to set common query options

It can be useful for debugging purposes to run the stress test with
custom query options, for example with codegen disabled. This patch adds
a command line option to the stress test entry point that allows a
caller to set query options.

To reduce support as new options are chosen, we allow freeform,
space-delimited option=value arguments as the option's value, like:

 --common_query_options option1=value1 ... optionN=valueN

This means we don't do much validation that these options and values are
well-formed.  Callers must take care to type the correct options and
values.

Testing: I ran concurrent_select.py by hand against an Impala cluster
with codegen both enabled and disabled, ala

 --common_query_options DISABLE_CODEGEN=true

Both the log written by concurrent_select.py and the Impala logs on the
cluster indicated DISABLE_CODEGEN was being set as I directed. I also
did negative testing for a few bad --common_query_options values. Either
concurrent_select.py catches the error, or when the first query runs,
the error is reported.

Change-Id: Iada041aace60c218a12178d8f1b9a68ff29de72e
Reviewed-on: http://gerrit.cloudera.org:8080/3887
Reviewed-by: David Knupp <dknupp@cloudera.com>
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Tim Armstrong <tarmstrong@cloudera.com>
(cherry picked from commit 9162d5d0544bf080da0a86331e9f77fc56803678)
---
M tests/stress/concurrent_select.py
1 file changed, 49 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/25/4225/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iada041aace60c218a12178d8f1b9a68ff29de72e
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message