impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR] IMPALA-3988: Only use first 96 bits of query id
Date Thu, 01 Sep 2016 19:44:57 GMT
Hello Marcel Kornacker,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4254

to review the following change.

Change subject: IMPALA-3988: Only use first 96 bits of query id
......................................................................

IMPALA-3988: Only use first 96 bits of query id

This adds utility functions in uid-util.h to create query and instance
ids and convert between them. It also adapts SimpleScheduler to
utilize those functions when creating the instance id
(TPlanFragmentInstanceCtx.fragment_instance_id).

Change-Id: Ia56a03ed9a1d7e77c72b66a01cd48c5b6bf3624f
Reviewed-on: http://gerrit.cloudera.org:8080/4065
Reviewed-by: Marcel Kornacker <marcel@cloudera.com>
Tested-by: Marcel Kornacker <marcel@cloudera.com>
(cherry picked from commit b69e469e99e4b0c08bc4718eb55b041cf7c11ffe)
---
M be/src/scheduling/simple-scheduler.cc
M be/src/service/impala-server.cc
M be/src/util/CMakeLists.txt
A be/src/util/uid-util-test.cc
M be/src/util/uid-util.h
M common/thrift/ImpalaInternalService.thrift
6 files changed, 96 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/54/4254/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4254
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia56a03ed9a1d7e77c72b66a01cd48c5b6bf3624f
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>

Mime
View raw message