impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR] IMPALA-3996: Migrate to updated Kudu insert string API
Date Thu, 01 Sep 2016 19:44:57 GMT
Hello Matthew Jacobs, Internal Jenkins,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4252

to review the following change.

Change subject: IMPALA-3996: Migrate to updated Kudu insert string API
......................................................................

IMPALA-3996: Migrate to updated Kudu insert string API

In Kudu 0.10 the Insert API changed for Strings and Binary
values to avoid ambiguity around memory copying. They
changed SetString() to copy the value given to it to avoid
misuse, and added a SetStringNoCopy() with the old behavior.

We upgraded to 0.10 which has some perf impact but is still
correct. This changes the code to use the NoCopy call which
was the behavior we had previously.

See Kudu commit:
https://github.com/apache/kudu/commit/48766a4ce17d422ced9a6ec78c9a9969ac44d8c9

Change-Id: I910c24724d0bc887b2d4a3e62ecdf72420a76f6f
Reviewed-on: http://gerrit.cloudera.org:8080/4055
Reviewed-by: Matthew Jacobs <mj@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit 6b5f9cf0f53d8a9b35182af81ffecb1351e8d477)
---
M be/src/exec/kudu-table-sink.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/52/4252/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4252
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I910c24724d0bc887b2d4a3e62ecdf72420a76f6f
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>

Mime
View raw message