impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR] IMPALA-3972: Improve display of /varz page
Date Thu, 01 Sep 2016 19:44:53 GMT
Hello Henry Robinson, Internal Jenkins,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4228

to review the following change.

Change subject: IMPALA-3972: Improve display of /varz page
......................................................................

IMPALA-3972: Improve display of /varz page

gflags has an API that returns metadata for all command-line flags. This
patch changes /varz to use that to generate a table view, where rows are
highlighted if the flag has changed from its default value.

Change-Id: I5a0d47da7abf913918d5fba5c327e26b73d701d2
Reviewed-on: http://gerrit.cloudera.org:8080/3941
Reviewed-by: Henry Robinson <henry@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit fe97579fe805b34bdccf4569ac626d11801a4823)
---
M be/src/util/default-path-handlers.cc
M www/common-header.tmpl
A www/flags.tmpl
3 files changed, 96 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/28/4228/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a0d47da7abf913918d5fba5c327e26b73d701d2
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message