impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool
Date Sun, 11 Sep 2016 00:36:13 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3201: reservation implementation for new buffer pool

IMPALA-3201: reservation implementation for new buffer pool

This patch implements the reservation bookkeeping logic for the new
buffer pool. The reservations are always guaranteed and any buffer/page
allocations require a reservation. Reservations are tracked via a
hierarchy of ReservationTrackers.

Eventually ReservationTrackers should become the main mechanism for
memory accounting, once all runtime memory is handled by the buffer
pool. In the meantime, query/process limits are enforced and memory
is reported through the preexisting MemTracker hierarchy.

Reservations are accounted as consumption against a MemTracker because
the memory is committed and cannot be used for other purposes. The
MemTracker then uses the counters from the ReservationTracker to log
information about buffer-pool memory down to the operator level.

Includes basic tests for buffer pool client registration and various
reservation operations.

Change-Id: I35cc89e863efb4cc506657bfdaaaf633a10bbab6
Reviewed-by: Tim Armstrong <>
Tested-by: Internal Jenkins
M be/CMakeLists.txt
A be/src/bufferpool/CMakeLists.txt
A be/src/bufferpool/
A be/src/bufferpool/
M be/src/bufferpool/buffer-pool.h
A be/src/bufferpool/reservation-tracker-counters.h
A be/src/bufferpool/
A be/src/bufferpool/
A be/src/bufferpool/reservation-tracker.h
M be/src/runtime/
M be/src/runtime/mem-tracker.h
A be/src/util/dummy-runtime-profile.h
M be/src/util/runtime-profile-counters.h
13 files changed, 1,439 insertions(+), 26 deletions(-)

  Internal Jenkins: Verified
  Tim Armstrong: Looks good to me, approved

To view, visit
To unsubscribe, visit

Gerrit-MessageType: merged
Gerrit-Change-Id: I35cc89e863efb4cc506657bfdaaaf633a10bbab6
Gerrit-PatchSet: 19
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tim Armstrong <>

View raw message