impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anonymous Coward (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4028: Trim sentry config file path spaces while impala start.
Date Sat, 10 Sep 2016 04:50:35 GMT
davyxdh@163.com has posted comments on this change.

Change subject: IMPALA-4028: Trim sentry config file path spaces while impala start.
......................................................................


Patch Set 2:

I have tested config file with name ended with spaces, impala can read this file correctly.

So command option tool unable to distinguish between a file containing spaces or wrong input.It
is unwisely simply trimming the spaces. 
File resolution within impala can distinguish and resolve the problem by 
trimming spaces and checking file again when original file verification failed.

-- 
To view, visit http://gerrit.cloudera.org:8080/4309
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a76b9e4236caa3f2088fba8a9cf0236fced2634
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: davyxdh@163.com
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: davyxdh@163.com
Gerrit-HasComments: No

Mime
View raw message