impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()
Date Fri, 09 Sep 2016 20:46:28 GMT
Hello Matthew Jacobs,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4125

to look at the new patch set (#9).

Change subject: IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()
......................................................................

IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()

To improve supportability, this commit logs the actual error stack trace
that can cause FileSystemUtil.copyToLocal() to fail. Additionaly this
also cleans up FileSystemUtil.isPathReachable() method to throw an
exception on failures rather than returning false and then returning
the error message as a string to callers.

Change-Id: I5664a75aa837951de1d5dcc90e43bd8f313736b8
---
M fe/src/main/java/com/cloudera/impala/analysis/HdfsUri.java
M fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/com/cloudera/impala/common/FileSystemUtil.java
M fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java
4 files changed, 19 insertions(+), 33 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/4125/9
-- 
To view, visit http://gerrit.cloudera.org:8080/4125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5664a75aa837951de1d5dcc90e43bd8f313736b8
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Brock Noland <brock@phdata.io>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message