impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Attila Jeges (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1616: Improve the Memory Limit Exceeded error report
Date Fri, 09 Sep 2016 10:10:41 GMT
Attila Jeges has posted comments on this change.

Change subject: IMPALA-1616: Improve the Memory Limit Exceeded error report
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4335/2/be/src/runtime/runtime-state.cc
File be/src/runtime/runtime-state.cc:

PS2, Line 250: From
> Maybe "by Fragment" ?
Done


Line 252:     DCHECK(tracker != NULL);
> The logging below adds spaces to the beginning of the string. Should we do 
I think the line indentations are intentional here. "Memory Limit Exceeded.." is the title/summary
of the report whereas the line below it contains more detailed information about the error.

Replaced "From Fragment" with "by Fragment" as Tim suggested above.


-- 
To view, visit http://gerrit.cloudera.org:8080/4335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb4e0c359d889938b4c351771ba539850bdb95ea
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message