impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3815: clean up cross-compiled comparator
Date Fri, 09 Sep 2016 02:40:47 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3815: clean up cross-compiled comparator
......................................................................


IMPALA-3815: clean up cross-compiled comparator

This avoids including a big block of interpreted code in the
cross-compiled IR and will make it easier to inline the Compare()
function into other codegened functions in a later change.

Perf:
Ran top-n targeted perf, didn't see any significant change.

Change-Id: I058917da2c13ba41d6ff7fefbb761606344312ab
Reviewed-on: http://gerrit.cloudera.org:8080/4307
Reviewed-by: Dan Hecht <dhecht@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/util/tuple-row-compare.cc
M be/src/util/tuple-row-compare.h
2 files changed, 38 insertions(+), 27 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Dan Hecht: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/4307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I058917da2c13ba41d6ff7fefbb761606344312ab
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message