impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4096: Allow clean.sh to work from snapshots
Date Thu, 08 Sep 2016 20:25:14 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4096: Allow clean.sh to work from snapshots
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4336/2/bin/clean.sh
File bin/clean.sh:

PS2, Line 77: -fdx
I just noticed this one is different from the other two. I think since you're touching the
line anyways it might make sense to use Xdfq here, too, especially since we probably want
to prefer -X (use gitignore) over -x (ignore gitignore) to avoid throwing away uncommitted
work. -q is quiet.


-- 
To view, visit http://gerrit.cloudera.org:8080/4336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12dd9035298151557491009680d66d25c8f58c1d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message