impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3905: Add single-threaded scan node.
Date Wed, 07 Sep 2016 22:41:29 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-3905: Add single-threaded scan node.
......................................................................


Patch Set 7: Code-Review+2

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4113/6/be/src/exec/hdfs-scan-node-base.h
File be/src/exec/hdfs-scan-node-base.h:

Line 304:   bool unknown_disk_id_warned_;
> Done
?


http://gerrit.cloudera.org:8080/#/c/4113/7/be/src/exec/hdfs-scan-node.h
File be/src/exec/hdfs-scan-node.h:

Line 104:     boost::lock_guard<SpinLock> l(file_type_counts_);
move to .cc, this isn't perf-critical and doesn't need to be inlined (it's nice to keep extra
fluff out of headers)


Line 141:   /// This lock cannot be taken together with any other lock except lock_.
what is required lock order?


-- 
To view, visit http://gerrit.cloudera.org:8080/4113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98cc7f970e1575dd83875609985e1877ada3d5e0
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message