impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3567: move ExecOption profile helpers to RuntimeProfile
Date Tue, 06 Sep 2016 22:00:31 GMT
Hello Matthew Jacobs, Alex Behm, Dan Hecht,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4188

to look at the new patch set (#5).

Change subject: IMPALA-3567: move ExecOption profile helpers to RuntimeProfile
......................................................................

IMPALA-3567: move ExecOption profile helpers to RuntimeProfile

This is groundwork for IMPALA-3567, which will move some logic that
previously resided in ExecNodes into DataSinks. We want to report
ExecOption strings consistently in both ExecNodes and DataSinks,
so that logic needs to move to a shared place (e.g. the RuntimeProfile
itself).

I ran the patch through clang-format, which changed line wrapping and
indentation of a few surrounding lines.

Change-Id: I21c1dda8f8a1d92172bf59fbc1070a6834e61913
---
M be/src/exec/aggregation-node.cc
M be/src/exec/blocking-join-node.cc
M be/src/exec/exec-node.cc
M be/src/exec/exec-node.h
M be/src/exec/hash-join-node.cc
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/partitioned-aggregation-node.cc
M be/src/exec/partitioned-hash-join-node.cc
M be/src/exec/sort-node.cc
M be/src/exec/topn-node.cc
M be/src/util/runtime-profile.cc
M be/src/util/runtime-profile.h
12 files changed, 114 insertions(+), 98 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/4188/5
-- 
To view, visit http://gerrit.cloudera.org:8080/4188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I21c1dda8f8a1d92172bf59fbc1070a6834e61913
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message