impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3567: move ExecOption profile helpers to RuntimeProfile
Date Tue, 06 Sep 2016 21:01:02 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3567: move ExecOption profile helpers to RuntimeProfile

Patch Set 3:

File be/src/util/

PS3, Line 465: ||
> does the clang formatter put this at the start of lines? this is opposite o
Yes, that was clang-format. It looks like there was a deliberate decision to set up clang-format
in this way:
File be/src/util/runtime-profile.h:

PS3, Line 207: Status
> Given that this function doesn't have anything to do with "Status" class, h
Did the rename.

It doesn't necessarily make sense to require it. Codegen can disabled by the disable_codegen
query option or planner. In that case status is ok because there was no error, but codegen
is disabled.

PS3, Line 211: OK
> is OK allowed even when !codegen_enabled?  Also, the bool and the Status se
They're partially independent. codegen_enabled implies status is ok, but vice-versa is not
true since codegen can be disabled by the planner or query option.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I21c1dda8f8a1d92172bf59fbc1070a6834e61913
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message