impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anonymous Coward (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3980: Re-enable Hive as a target database for the Random Query Generator
Date Mon, 05 Sep 2016 23:22:17 GMT
stakiar@cloudera.com has uploaded a new patch set (#2).

Change subject: IMPALA-3980: Re-enable Hive as a target database for the Random Query Generator
......................................................................

IMPALA-3980: Re-enable Hive as a target database for the Random Query Generator

Changes:

* Added hive cli options back in (removed in commit "Stress test: Various changes")
* Modifications so that if --use-hive is specified, a Hive connection is actually created
* A few minor bug fixes so that the RQG can be run locally
* Modified MiniCluster to use HADOOP_CONF_DIR and HIVE_CONF_DIR rather than a hard-coded
file under IMPALA_HOME

Testing:

* Hive integration tested locally by invoking the data generator (./data-generator.py
--db-name=functional --use-hive --min-row-count=50 --max-row-count=100
--storage-file-formats textfile --use-postgresql --postgresql-user stakiar) and the
discrepancy checker (./discrepancy-checker.py --db-name=functional --use-hive
--use-postgresql --postgresql-user stakiar --test-db-type HIVE --timeout 300
--query-count 50 --profile hive)
* The output of the above two commands is essentially the same as the Impala output,
however, about 20% of the queries will fail when the discrepancy checker is run
* Regression testing done by running Leopard in a local VM running Ubuntu 14.04, and by
running the discrepancy checker against Impala while inside an Impala Docker container

Change-Id: Ifb1199b50a5b65c21de7876fb70cc03bda1a9b46
---
M tests/comparison/cli_options.py
M tests/comparison/cluster.py
M tests/comparison/data_generator.py
3 files changed, 57 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/4011/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb1199b50a5b65c21de7876fb70cc03bda1a9b46
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: stakiar@cloudera.com
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: stakiar@cloudera.com

Mime
View raw message