impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Ivanfi (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Minor enhancements to helper scripts.
Date Mon, 05 Sep 2016 11:45:16 GMT
Zoltan Ivanfi has posted comments on this change.

Change subject: Minor enhancements to helper scripts.
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4304/3/testdata/bin/copy-udfs-udas.sh
File testdata/bin/copy-udfs-udas.sh:

PS3, Line 51: "-j${IMPALA_BUILD_THREADS:-4}"
> quotes don't seem necessary here
They are not strictly necessary, unless someone abuses the IMPALA_BUILD_THREADS variable.
It is recommended to always quote variables in shell scripts just to be sure (https://google.github.io/styleguide/shell.xml#Variable_expansion,
http://www.dwheeler.com/essays/filenames-in-shell.html#doublequote).


-- 
To view, visit http://gerrit.cloudera.org:8080/4304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic90bd0048786c799a8ac435de4303ed399ac1223
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zoltan Ivanfi <zi@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message