impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation
Date Fri, 02 Sep 2016 22:28:27 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation

Patch Set 5:

File be/src/service/

PS5, Line 171: lock_guard<SpinLock> lock(lock_);
> you can avoid this if status.ok(), I think. Not sure if it's worth it.
I can combine this block with the if() below, works out shorter.

Line 185:   if (thread == NULL) return Status::OK();
> DCHECK(is_cancelled_)? I think that's the only time that thread == nullptr.
It's also false if we never ran any child queries. Added     DCHECK(!is_running_).
File be/src/service/child-query.h:

PS5, Line 148: is
> must be

PS5, Line 178: Exec
> Is there a more descriptive name than Exec()? Every class seems to have an 

Line 194:   bool is_running_;
> Comment here that, once started, the queries must be allowed to complete or
File be/src/service/query-exec-state.h:

PS5, Line 226: Acquires
> Acquirers

PS5, Line 227: acquired
> required
I think I actually intended acquired, but "required" also works.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe3024803e03595ee69c47759b58e8443d7bd167
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message