impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4058: benchmark byteswap on misaligned memory
Date Fri, 02 Sep 2016 20:26:19 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-4058: benchmark byteswap on misaligned memory
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4290/4/be/src/benchmarks/bswap-benchmark.cc
File be/src/benchmarks/bswap-benchmark.cc:

Line 20: #include <iostream>
nit: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes


-- 
To view, visit http://gerrit.cloudera.org:8080/4290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9dfcca718b2456488d0fb4407d3817c796bfad0
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message