impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4056: Fix toSql() of DistributeParam
Date Fri, 02 Sep 2016 20:11:29 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4056: Fix toSql() of DistributeParam
......................................................................


IMPALA-4056: Fix toSql() of DistributeParam

This commit fixes two issues in toSql() of DistributeParam:
1. string literals were not quoted
2. range partition split rows were not printed.
Besides, this commit fixes a small issue in run-hive-server.sh

Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931
Reviewed-on: http://gerrit.cloudera.org:8080/4195
Reviewed-by: Matthew Jacobs <mj@cloudera.com>
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Internal Jenkins
---
M fe/src/main/java/com/cloudera/impala/analysis/DistributeParam.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeDDLTest.java
M testdata/bin/run-hive-server.sh
M testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test
4 files changed, 22 insertions(+), 22 deletions(-)

Approvals:
  Matthew Jacobs: Looks good to me, but someone else must approve
  Internal Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/4195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <luoyuanhao@software.ict.ac.cn>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <luoyuanhao@software.ict.ac.cn>

Mime
View raw message