impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Minor enhancements to helper scripts.
Date Fri, 02 Sep 2016 19:09:48 GMT
Tim Armstrong has posted comments on this change.

Change subject: Minor enhancements to helper scripts.
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4304/2/bin/run-all-tests.sh
File bin/run-all-tests.sh:

Line 104: ulimit -c unlimited ||:
|| true 

for consistency with the rest of the scripts (one less bash feature for people to understand).


http://gerrit.cloudera.org:8080/#/c/4304/2/testdata/bin/copy-udfs-udas.sh
File testdata/bin/copy-udfs-udas.sh:

Line 51:   "${MAKE_CMD:-make}" -j$CORES \
Nice catch, looks like I missed this one.


PS2, Line 51: CORES
Can you make this -j${IMPALA_BUILD_THREADS:-4} for consistency with other make invocations?


-- 
To view, visit http://gerrit.cloudera.org:8080/4304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic90bd0048786c799a8ac435de4303ed399ac1223
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zoltan Ivanfi <zi@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message