impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.
Date Thu, 01 Sep 2016 16:43:16 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4205/3/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

Line 1931:   TestStringValue("reverse('abcdefg')", "gfedcba");
> I think let's just make it a separate test, the long functions are fine whe
Done in PS 5.


http://gerrit.cloudera.org:8080/#/c/4205/3/be/src/util/bit-util.cc
File be/src/util/bit-util.cc:

Line 161:   _mm_storeu_si128(reinterpret_cast<__m128i*>(dst + 16), part1);
> What's the perf impact?  I assume we still benefit from specializing this r
I ran the benchmark and the AVX2 version is still >3x faster than the SSSE3 version.


-- 
To view, visit http://gerrit.cloudera.org:8080/4205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39b2b47bb717d5ac9727512a24fcf8a8a6a8dcc6
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Youwei Wang <youwei.a.wang@intel.com>
Gerrit-HasComments: Yes

Mime
View raw message