impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.
Date Thu, 01 Sep 2016 13:16:07 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.
......................................................................


Patch Set 2:

> Greetings, All.
 > @Jim, considering the string reverse function is using the SIMDed
 > Byteswap as internal implementation, do you thinkt it is okay to
 > merge some test cases from this? https://gerrit.cloudera.org/#/c/4204/1/be/src/exprs/expr-test.cc
 > Thank you :D

What do you mean by "merge some test cases from"?

-- 
To view, visit http://gerrit.cloudera.org:8080/4205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39b2b47bb717d5ac9727512a24fcf8a8a6a8dcc6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Youwei Wang <youwei.a.wang@intel.com>
Gerrit-HasComments: No

Mime
View raw message