impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Youwei Wang (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Impala-4058: unaligned memory access issue in SIMDed byteswap.
Date Thu, 01 Sep 2016 09:05:20 GMT
Youwei Wang has uploaded a new patch set (#2).

Change subject: Impala-4058: unaligned memory access issue in SIMDed byteswap.
......................................................................

Impala-4058: unaligned memory access issue in SIMDed byteswap.

Substitute the direct memory assignments using _mm_loadu_si128/_mm_storeu_si128
to prevent the compiler from generating aligned memory access instructions which
may cause crash.
Add new test cases in the expr-test.cc and re-run the bswap-benchmark.
No performance regression observed.

Change-Id: I2986991f8b695d68af465fd0aff293d3d03709a0
---
M be/src/benchmarks/bswap-benchmark.cc
M be/src/exprs/expr-test.cc
M be/src/util/bit-util.cc
3 files changed, 38 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/98/4198/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2986991f8b695d68af465fd0aff293d3d03709a0
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Youwei Wang <youwei.a.wang@intel.com>

Mime
View raw message