Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 59A83200B6B for ; Thu, 25 Aug 2016 23:27:18 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 541AF160ABD; Thu, 25 Aug 2016 21:27:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9ABDE160AA4 for ; Thu, 25 Aug 2016 23:27:02 +0200 (CEST) Received: (qmail 49926 invoked by uid 500); 25 Aug 2016 21:26:51 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 49915 invoked by uid 99); 25 Aug 2016 21:26:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Aug 2016 21:26:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 38013C639E for ; Thu, 25 Aug 2016 21:26:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 9avuSMECtNir for ; Thu, 25 Aug 2016 21:26:49 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 70E075F471 for ; Thu, 25 Aug 2016 21:26:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u7PLQlYx029215; Thu, 25 Aug 2016 21:26:47 GMT Date: Thu, 25 Aug 2016 21:26:47 +0000 From: "Jim Apple (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Jim Apple Message-ID: Reply-To: jbapple@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Stricter_clang-format=3A_set_DerivePointerAlignment_to_false=2E=0A?= X-Gerrit-Change-Id: I713cdd68af741c7cba9e2c5704f20b8901c9e5f6 X-Gerrit-ChangeURL: X-Gerrit-Commit: f3849e236886ce6573fc27a2baf8f5e8fc15d878 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 25 Aug 2016 21:27:18 -0000 Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4127 Change subject: Stricter clang-format: set DerivePointerAlignment to false. ...................................................................... Stricter clang-format: set DerivePointerAlignment to false. The description of DerivePointerAlignment, which is set to true in the Google style, is If true, analyze the formatted file for the most common alignment of & and *. PointerAlignment is then used only as fallback. (PointerAlignment is Left, meaning "char* x", not "char *x" (Right) or "char * x" (Middle)) The virtue of setting DerivePointerAlignment to false is that it will prevent new contributors from setting the pointers in the wrong place in a new file or in a file they are modifying heavily. Change-Id: I713cdd68af741c7cba9e2c5704f20b8901c9e5f6 --- M .clang-format 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/4127/1 -- To view, visit http://gerrit.cloudera.org:8080/4127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I713cdd68af741c7cba9e2c5704f20b8901c9e5f6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple