Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E8241200B71 for ; Wed, 31 Aug 2016 22:16:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E6908160AB4; Wed, 31 Aug 2016 20:16:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 39586160AA7 for ; Wed, 31 Aug 2016 22:16:15 +0200 (CEST) Received: (qmail 87053 invoked by uid 500); 31 Aug 2016 20:16:14 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 87040 invoked by uid 99); 31 Aug 2016 20:16:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Aug 2016 20:16:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id BAF36C0D9B for ; Wed, 31 Aug 2016 20:16:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 84gffab9QDdr for ; Wed, 31 Aug 2016 20:16:11 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id 98F065F1B8 for ; Wed, 31 Aug 2016 20:16:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u7VKG8YE001202; Wed, 31 Aug 2016 20:16:08 GMT Message-Id: <201608312016.u7VKG8YE001202@ip-10-146-233-104.ec2.internal> Date: Wed, 31 Aug 2016 20:16:08 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Michael Ho , Lars Volker Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4051=3A_Avoid_unnecessary_copy_of_RowDescriptor_into_RowBatch=0A?= X-Gerrit-Change-Id: I27c05090ee8b9dd9d650a5587a3ae42839aa0008 X-Gerrit-ChangeURL: X-Gerrit-Commit: da8a177c3f1ad7dd7f6946491fd8995f43719149 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 31 Aug 2016 20:16:16 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-4051: Avoid unnecessary copy of RowDescriptor into RowBatch ...................................................................... Patch Set 2: Michael Ho pointed out that I was wrong in assuming that the RowDescriptors live in the DescriptorTbl (they don't). So for this to be more correct I really need to rework the lifetime of the RowDescriptors. -- To view, visit http://gerrit.cloudera.org:8080/4181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27c05090ee8b9dd9d650a5587a3ae42839aa0008 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No