Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
Message-Id: <201608310135.u7V1ZdsK011880@ip-10-146-233-104.ec2.internal>
Date: Wed, 31 Aug 2016 01:35:39 +0000
From: "Marcel Kornacker (Code Review)" <gerrit@cloudera.org>
To: Sailesh Mukil <sailesh@cloudera.com>, impala-cr@cloudera.com,
        dev@impala.incubator.apache.org
CC: Lars Volker <lv@cloudera.com>, Henry Robinson <henry@cloudera.com>,
        Dan Hecht <dhecht@cloudera.com>, David Knupp <dknupp@cloudera.com>,
        Matthew Jacobs <mj@cloudera.com>
Reply-To: marcel@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4014=3A_Introduce_query-wide_execution_state=2E=0A?=
In-Reply-To: <gerrit.1469818503000.I892091d6401acb2ea91ccb1623af54c6f9635e6c@gerrit.cloudera.org>
References: <gerrit.1469818503000.I892091d6401acb2ea91ccb1623af54c6f9635e6c@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Wed, 31 Aug 2016 01:35:43 -0000

Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4014: Introduce query-wide execution state.
......................................................................


Patch Set 11:

> From the discussion today:
 > 
 > Points agreed on:
 > - Collapse Executors and states, i.e. collapse FragmentInstanceExecutor
 > into FragmentInstanceState, so that responsibilities and boundaries
 > of classes are clear.
 > 
 > - QueryExecMgr is still responsible for setting up the QueryState
 > and creating the fragment threads for now. Once the per-query RPC
 > is implemented, the model will change such that QueryExecMgr
 > creates a “query" thread which sets up the QueryState and starts
 > the fragment threads.

Small correction: once we have the per-query rpc we'll still have QEM create the QueryState and register it before starting the query thread (which then starts the fragment instance threads).

 > 
 > Additionally, I'll put out a separate patch with *only* headers
 > that are parallel with the existing headers, so that Lars can use
 > that to work on the per-query RPC.

-- 
To view, visit http://gerrit.cloudera.org:8080/3817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I892091d6401acb2ea91ccb1623af54c6f9635e6c
Gerrit-PatchSet: 11
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: No