Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CF99B200B6B for ; Fri, 26 Aug 2016 02:24:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CDEEB160ABD; Fri, 26 Aug 2016 00:24:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1D567160AA5 for ; Fri, 26 Aug 2016 02:24:13 +0200 (CEST) Received: (qmail 36340 invoked by uid 500); 26 Aug 2016 00:24:13 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 36325 invoked by uid 99); 26 Aug 2016 00:24:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Aug 2016 00:24:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 841771A12B7 for ; Fri, 26 Aug 2016 00:24:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id PZDhNPxmTtxg for ; Fri, 26 Aug 2016 00:24:11 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 442D15F471 for ; Fri, 26 Aug 2016 00:24:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u7Q0OArn004476; Fri, 26 Aug 2016 00:24:10 GMT Message-Id: <201608260024.u7Q0OArn004476@ip-10-146-233-104.ec2.internal> Date: Fri, 26 Aug 2016 00:24:10 +0000 From: "Bharath Vissapragada (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Matthew Jacobs Reply-To: bharathv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3949=3A_Log_the_error_message_in_FileSystemUtil=2EcopyToLocal=28=29=0A?= X-Gerrit-Change-Id: I5664a75aa837951de1d5dcc90e43bd8f313736b8 X-Gerrit-ChangeURL: X-Gerrit-Commit: a54fc59fa187d6ac629000493e1dc9d23bc5cdaf In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Fri, 26 Aug 2016 00:24:15 -0000 Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal() ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4125/2/fe/src/main/java/com/cloudera/impala/common/FileSystemUtil.java File fe/src/main/java/com/cloudera/impala/common/FileSystemUtil.java: PS2, Line 375: Copies the source file to a destination path on the local filesystem and returns true : * if successful. > Can you add a comment here about errorTrace? (And that it is the full stack Done PS2, Line 390: Return true if the path can be reached, false for all other cases : * File doesn't exist, cannot access the FileSystem, etc. > Also please comment here about errorMsg. It'd be good to call out this is a Done -- To view, visit http://gerrit.cloudera.org:8080/4125 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5664a75aa837951de1d5dcc90e43bd8f313736b8 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: Yes