Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
Message-Id: <201608221729.u7MHT5YY029572@ip-10-146-233-104.ec2.internal>
Date: Mon, 22 Aug 2016 17:29:05 +0000
From: "Alex Behm (Code Review)" <gerrit@cloudera.org>
To: Marcel Kornacker <marcel@cloudera.com>, impala-cr@cloudera.com,
        dev@impala.incubator.apache.org
CC: Henry Robinson <henry@cloudera.com>, Matthew Jacobs <mj@cloudera.com>,
        Dan Hecht <dhecht@cloudera.com>
Reply-To: alex.behm@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3902=3A_Scheduler_improvements_for_running_multiple_fragment_instances_on_a_single_backend=0A?=
In-Reply-To: <gerrit.1471565970000.I240445199e22f009f4e72fdb8754eb8d77e3d680@gerrit.cloudera.org>
References: <gerrit.1471565970000.I240445199e22f009f4e72fdb8754eb8d77e3d680@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Mon, 22 Aug 2016 17:29:10 -0000

Alex Behm has posted comments on this change.

Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4054/3/fe/src/main/java/com/cloudera/impala/service/Frontend.java
File fe/src/main/java/com/cloudera/impala/service/Frontend.java:

Line 964:       planner.computeResourceReqs(fragments, true, queryExecRequest);
> anything llama-related is going to be removed for the next release. i'll le
so we are going to remove the resource estimates reported in the explain plan altogether? you might be surprised that some users rely on them


Line 1042:     for (int idx = 0; idx < fragments.size(); ++idx) {
> all of the non-mt paths (meaning the functions for which this patch creates
Fair enough, but I don't see the old code going away anytime soon (i.e. several quarters). We can refactor later if the maintenance does become a problem.


-- 
To view, visit http://gerrit.cloudera.org:8080/4054
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I240445199e22f009f4e72fdb8754eb8d77e3d680
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes