Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C74B1200B78 for ; Fri, 19 Aug 2016 08:04:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C5D8A160AB7; Fri, 19 Aug 2016 06:04:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 19AD9160AAE for ; Fri, 19 Aug 2016 08:04:23 +0200 (CEST) Received: (qmail 94251 invoked by uid 500); 19 Aug 2016 06:04:23 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 94234 invoked by uid 99); 19 Aug 2016 06:04:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Aug 2016 06:04:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 728B8C034D for ; Fri, 19 Aug 2016 06:04:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 3SA4lhE-b8hA for ; Fri, 19 Aug 2016 06:04:20 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id CB0415FB37 for ; Fri, 19 Aug 2016 06:04:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u7J64IVx013737; Fri, 19 Aug 2016 06:04:18 GMT Message-Id: <201608190604.u7J64IVx013737@ip-10-146-233-104.ec2.internal> Date: Fri, 19 Aug 2016 06:04:18 +0000 From: "Internal Jenkins (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, dev@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Add_functional_and_targeted_perf_tests_for_joins_with_empty_builds=0A?= X-Gerrit-Change-Id: I0a68cafec32011a47c569b254979601237e7f2a5 X-Gerrit-ChangeURL: X-Gerrit-Commit: f613dcd02da989204026999b26247a024fb199ab In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Fri, 19 Aug 2016 06:04:25 -0000 Internal Jenkins has submitted this change and it was merged. Change subject: Add functional and targeted perf tests for joins with empty builds ...................................................................... Add functional and targeted perf tests for joins with empty builds I wrote these tests for my IMPALA-3987 patch, but other issues block that optimisations. These tests exercise an interesting corner case so I split them out into a separate patch. The functional tests exercise every join mode for nested loop join and hash join with an empty build side. The perf test exercises hash join with an empty build side. Testing: Made sure the tests passed with both partitioned and non-partitioned hash join implementations. Ran the targeted perf query through the single node perf run script to make sure it worked. Change-Id: I0a68cafec32011a47c569b254979601237e7f2a5 Reviewed-on: http://gerrit.cloudera.org:8080/4051 Reviewed-by: Tim Armstrong Tested-by: Internal Jenkins --- A testdata/workloads/functional-query/queries/QueryTest/empty-build-joins.test M testdata/workloads/functional-query/queries/QueryTest/single-node-nlj.test A testdata/workloads/targeted-perf/queries/primitive_empty_build_join_1.test M tests/query_test/test_join_queries.py 4 files changed, 262 insertions(+), 0 deletions(-) Approvals: Internal Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/4051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a68cafec32011a47c569b254979601237e7f2a5 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Tim Armstrong