Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5A91D200B66 for ; Thu, 18 Aug 2016 19:41:58 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5927D160AAE; Thu, 18 Aug 2016 17:41:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9D63F160A86 for ; Thu, 18 Aug 2016 19:41:57 +0200 (CEST) Received: (qmail 47449 invoked by uid 500); 18 Aug 2016 17:41:56 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 47437 invoked by uid 99); 18 Aug 2016 17:41:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Aug 2016 17:41:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1B3901A129F for ; Thu, 18 Aug 2016 17:41:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id cw96z2-56PIh for ; Thu, 18 Aug 2016 17:41:54 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 8B3BD5FBB8 for ; Thu, 18 Aug 2016 17:41:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u7IHfqAQ026226; Thu, 18 Aug 2016 17:41:52 GMT Message-Id: <201608181741.u7IHfqAQ026226@ip-10-146-233-104.ec2.internal> Date: Thu, 18 Aug 2016 17:41:52 +0000 From: "Sailesh Mukil (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: sailesh@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2988=3A_Refactor_HdfsTableSink=3A=3AClose=28=29_so_that_it_cannot_fail=0A?= X-Gerrit-Change-Id: I2546bc68ba136b2713d744c1b920878606a2217b X-Gerrit-ChangeURL: X-Gerrit-Commit: 18eeb9c809264c556b9bee919c633fb9ed9fbb41 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 18 Aug 2016 17:41:58 -0000 Sailesh Mukil has posted comments on this change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail ...................................................................... Patch Set 1: > > Uploaded patch set 1. > > Contingent on success of the following private build: > http://sandbox.jenkins.cloudera.com/view/Impala/view/Private-Utility/job/impala-private-build-and-test/3969/ This failed some tests, so will fix and post another patch. -- To view, visit http://gerrit.cloudera.org:8080/4018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2546bc68ba136b2713d744c1b920878606a2217b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No