Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 276C8200B65 for ; Wed, 17 Aug 2016 21:46:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 25F33160A8C; Wed, 17 Aug 2016 19:46:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6EEF7160A6C for ; Wed, 17 Aug 2016 21:46:24 +0200 (CEST) Received: (qmail 68187 invoked by uid 500); 17 Aug 2016 19:46:23 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 68175 invoked by uid 99); 17 Aug 2016 19:46:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Aug 2016 19:46:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 108081A583E for ; Wed, 17 Aug 2016 19:46:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Kpr9oMBUiVcf for ; Wed, 17 Aug 2016 19:46:19 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id A82035FBDE for ; Wed, 17 Aug 2016 19:46:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u7HJkHaU030875; Wed, 17 Aug 2016 19:46:17 GMT Message-Id: <201608171946.u7HJkHaU030875@ip-10-146-233-104.ec2.internal> Date: Wed, 17 Aug 2016 19:46:17 +0000 From: "Michael Brown (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: mikeb@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Fix_stress_test_runner_bug_introduced_by_IMPALA-3969=0A?= X-Gerrit-Change-Id: I86484bb7c92ae1069f6a07cf3ea5027740364150 X-Gerrit-ChangeURL: X-Gerrit-Commit: c53fd12ff5c7002e1c1e638e014f58f65df68c15 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 17 Aug 2016 19:46:25 -0000 Michael Brown has posted comments on this change. Change subject: Fix stress test runner bug introduced by IMPALA-3969 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4019/1/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: PS1, Line 705: self.common_query_options = {} Thanks. In haste, I think I mistook L680 for what should have gone here, instead, and it's on me for not having tested the path. I think we could delete L680. Do you agree? -- To view, visit http://gerrit.cloudera.org:8080/4019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86484bb7c92ae1069f6a07cf3ea5027740364150 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes