Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
Message-Id: <201608152149.u7FLnpm0011652@ip-10-146-233-104.ec2.internal>
Date: Mon, 15 Aug 2016 21:49:51 +0000
From: "Henry Robinson (Code Review)" <gerrit@cloudera.org>
To: Jim Apple <jbapple@cloudera.com>, impala-cr@cloudera.com,
        dev@impala.incubator.apache.org
CC: Tim Armstrong <tarmstrong@cloudera.com>, Lars Volker <lv@cloudera.com>
Reply-To: henry@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Add_=2Eclang-format_for_Impala=27s_C++_style=0A?=
In-Reply-To: <gerrit.1470851339000.I274c5993c7be344fc4b7729d21a13da993f9f3aa@gerrit.cloudera.org>
References: <gerrit.1470851339000.I274c5993c7be344fc4b7729d21a13da993f9f3aa@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Mon, 15 Aug 2016 21:49:57 -0000

Henry Robinson has posted comments on this change.

Change subject: Add .clang-format for Impala's C++ style
......................................................................


Patch Set 1:

I ran this over a few patches. Some small things I noticed:

1. The arg-breaking behaviour is different: the formatter prefers to put all arguments on one line even if that means adding a newline before the first one.

2. for (auto& foo: bar) -> for (auto& foo : bar). I don't care about this one, all the same to me.

3. Indentation on constructor member initialisation lists is by two spaces, not four (i.e. line up with the ':'). Again, I don't care about that. 

I don't see any problems with these small changes, but you might want to socialise this a bit on impala-dev@ before committing the formatter. It would be excellent for this to be as close to our canonical style as possible, even if that means changing our canonical style a bit.

-- 
To view, visit http://gerrit.cloudera.org:8080/3886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I274c5993c7be344fc4b7729d21a13da993f9f3aa
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No