Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B9EC4200B63 for ; Mon, 15 Aug 2016 23:16:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B38F6160AA7; Mon, 15 Aug 2016 21:16:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 06120160A8A for ; Mon, 15 Aug 2016 23:15:59 +0200 (CEST) Received: (qmail 63406 invoked by uid 500); 15 Aug 2016 21:15:59 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 63391 invoked by uid 99); 15 Aug 2016 21:15:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Aug 2016 21:15:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9915BC17A0 for ; Mon, 15 Aug 2016 21:15:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id G-aN21kTcvaH for ; Mon, 15 Aug 2016 21:15:54 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id AE6605F472 for ; Mon, 15 Aug 2016 21:15:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u7FLFrDt009534; Mon, 15 Aug 2016 21:15:53 GMT Message-Id: <201608152115.u7FLFrDt009534@ip-10-146-233-104.ec2.internal> Date: Mon, 15 Aug 2016 21:15:53 +0000 From: "Marcel Kornacker (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Dan Hecht Reply-To: marcel@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3201=3A_buffer_pool_header_only=0A?= X-Gerrit-Change-Id: Id771dea2eb4c1aa13c30d59e8b184a7d1bca8d34 X-Gerrit-ChangeURL: X-Gerrit-Commit: 3be30dc276b21b66194c5b8680bb1b886699412c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Mon, 15 Aug 2016 21:16:00 -0000 Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3201: buffer pool header only ...................................................................... Patch Set 7: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3688/7/be/src/bufferpool/buffer-pool.h File be/src/bufferpool/buffer-pool.h: Line 218: /// reservation in 'src_client'. 'src' must be open and 'dst' must be closed before > how do you get a closed BufferHandle, other than calling allocate and free we can decide to change this later, if the code that calls this ends up looking awkward, i just wanted to point this out as something odd. -- To view, visit http://gerrit.cloudera.org:8080/3688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id771dea2eb4c1aa13c30d59e8b184a7d1bca8d34 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes