Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 613FB200B5E for ; Wed, 10 Aug 2016 23:35:41 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5FE3A160AA4; Wed, 10 Aug 2016 21:35:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A7249160A8F for ; Wed, 10 Aug 2016 23:35:40 +0200 (CEST) Received: (qmail 78941 invoked by uid 500); 10 Aug 2016 21:35:39 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 78930 invoked by uid 99); 10 Aug 2016 21:35:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Aug 2016 21:35:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 48EF31A52A8 for ; Wed, 10 Aug 2016 21:35:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id XFrBA8ERC9ss for ; Wed, 10 Aug 2016 21:35:38 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 0C6E95F471 for ; Wed, 10 Aug 2016 21:35:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u7ALZaXj005476; Wed, 10 Aug 2016 21:35:37 GMT Message-Id: <201608102135.u7ALZaXj005476@ip-10-146-233-104.ec2.internal> Date: Wed, 10 Aug 2016 21:35:36 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Dan Hecht Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3764=2C3914=3A_fuzz_test_HDFS_scanners_and_fix_parquet_bugs_found=0A?= X-Gerrit-Change-Id: I50cf43195a7c582caa02c85ae400ea2256fa3a3b X-Gerrit-ChangeURL: X-Gerrit-Commit: 799750c5eecfed90413259151a7a5082f13c3dad In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 10 Aug 2016 21:35:41 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-3764,3914: fuzz test HDFS scanners and fix parquet bugs found ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/3833/6/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 313: if (UNLIKELY(file_metadata_.num_rows < 0)) { > would it be better to do this check upstream? are there no other code paths Good point, moved it to ProcessFooter() PS6, Line 317: CHECK_LE > why CHECK? Typo. Done -- To view, visit http://gerrit.cloudera.org:8080/3833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50cf43195a7c582caa02c85ae400ea2256fa3a3b Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes