Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5D7B3200B5E for ; Wed, 10 Aug 2016 22:23:43 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5C0BD160AB1; Wed, 10 Aug 2016 20:23:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A0E5F160A8F for ; Wed, 10 Aug 2016 22:23:42 +0200 (CEST) Received: (qmail 69893 invoked by uid 500); 10 Aug 2016 20:23:41 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 69878 invoked by uid 99); 10 Aug 2016 20:23:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Aug 2016 20:23:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3D54EC222F for ; Wed, 10 Aug 2016 20:23:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 1nO7wN8x2qud for ; Wed, 10 Aug 2016 20:23:39 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 596EB5FAE8 for ; Wed, 10 Aug 2016 20:23:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u7AKNcqF001142; Wed, 10 Aug 2016 20:23:38 GMT Message-Id: <201608102023.u7AKNcqF001142@ip-10-146-233-104.ec2.internal> Date: Wed, 10 Aug 2016 20:23:38 +0000 From: "Thomas Tauber-Marshall (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Tim Armstrong , Michael Ho Reply-To: tmarshall@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3629=3A_Codegen_TransferScratchTuples=28=29_in_hdfs-parquet-scanner=0A?= X-Gerrit-Change-Id: Ic327e437c7cd2b3f92cdb11c1e907bfee2d44ee8 X-Gerrit-ChangeURL: X-Gerrit-Commit: fdcbc68a3581bcb7089545df825040d7c719b275 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 10 Aug 2016 20:23:43 -0000 Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/3774/5/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: PS5, Line 668: s > 'status' I think is a little clearer. Done PS5, Line 689: fn == NULL > The value of fn is undefined in some cases here if the above functions retu Done http://gerrit.cloudera.org:8080/#/c/3774/5/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: Line 689: *write_aligned_tuples_fn = NULL; > I think this and the other functions should initialise their output argumen Done http://gerrit.cloudera.org:8080/#/c/3774/5/be/src/exec/hdfs-text-scanner.h File be/src/exec/hdfs-text-scanner.h: Line 62: /// status of the codegen, or OK if codegen is disabled. > Line wrapping looks weird here. Done -- To view, visit http://gerrit.cloudera.org:8080/3774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic327e437c7cd2b3f92cdb11c1e907bfee2d44ee8 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes